git/fetch.c, branch v0.99.8e

[PATCH] Implement --recover for git-*-fetch

2005-09-27T07:16:40Z

With the --recover option, we verify that we have absolutely everything reachable from the target, not assuming that things reachable from refs will be complete. Signed-off-by: Daniel Barkalow Signed-off-by: Junio C Hamano

[PATCH] fetch.c: Plug memory leak in process_tree()

2005-09-23T21:30:45Z

When freeing a tree entry, must free its name too. Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano

[PATCH] fetch.c: Do not build object ref lists

2005-09-23T21:30:42Z

The fetch code does not need object ref lists; by disabling them we can save some time and memory. Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano

[PATCH] fetch.c: Remove call to parse_object() from process()

2005-09-23T04:52:12Z

The call to parse_object() in process() is not actually needed - if the object type is unknown, parse_object() will be called by loop(); if the type is known, the object will be parsed by the appropriate process_*() function. After this change blobs which exist locally are no longer parsed, which gives about 2x CPU usage improvement; the downside is that there will be no warnings for existing corrupted blobs, but detecting such corruption is the job of git-fsck-objects, not the fetch programs. Newly fetched objects are still checked for corruption in http-fetch.c and ssh-fetch.c (local-fetch.c does not seem to do it, but the removed parse_object() call would not be reached for new objects anyway). Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano

[PATCH] fetch.c: Clean up object flag definitions

2005-09-23T04:52:11Z

Remove holes left after deleting flags, and use shifts to emphasize that flags are single bits. Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano

[PATCH] fetch.c: Remove redundant test of TO_SCAN in process()

2005-09-23T04:52:11Z

If the SEEN flag was not set, the TO_SCAN flag cannot be set, therefore testing it is pointless. Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano

[PATCH] fetch.c: Remove some duplicated code in process()

2005-09-23T04:52:11Z

It does not matter if we call prefetch() or set the TO_SCAN flag before or after adding the object to process_queue. However, doing it before object_list_insert() allows us to kill 3 lines of duplicated code. Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano

[PATCH] fetch.c: Remove redundant TO_FETCH flag

2005-09-23T04:52:11Z

The TO_FETCH flag also became redundant after adding the SEEN flag - it was set and checked in process() to prevent adding the same object to process_queue multiple times, but now SEEN guards against this. Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano

[PATCH] fetch.c: Remove redundant SCANNED flag

2005-09-23T04:52:11Z

After adding the SEEN flag, the SCANNED flag became obviously redundant - each object can get into process_queue through process() only once, and therefore multiple calls to process_object() for the same object are not possible. Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano

[PATCH] fetch.c: Make process() look at each object only once

2005-09-23T04:52:11Z

The process() function is very often called multiple times for the same object (because lots of trees refer to the same blobs), but did not have a fast check for this, therefore a lot of useless calls to has_sha1_file() and parse_object() were made before discovering that nothing needs to be done. This patch adds the SEEN flag which is used in process() to make it look at each object only once. When testing git-local-fetch on the repository of GIT, this gives a 14x improvement in CPU usage (mainly because the redundant calls to parse_object() are now avoided - parse_object() always unpacks and parses the object data, even if it was already parsed before). Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano