git/gitweb, branch v1.5.2

gitweb: Fix "Use of uninitialized value" warning in git_feed

2007-05-19T02:49:45Z

Initial (root) commit has no parents, and $co{'parent'} is undefined. Use '--root' for initial commit. This fixes "Use of uninitialized value in open at gitweb/gitweb.perl line 4925." warning. Signed-off-by: Jakub Narebski Signed-off-by: Junio C Hamano

gitweb: Remove redundant $searchtype setup

2007-05-19T00:12:36Z

Sorry, this was inadverently introduced by my grep search patch. It causes annoying "redefined" warnings. Signed-off-by: Petr Baudis Signed-off-by: Junio C Hamano

gitweb: Allow arbitrary strings to be dug with pickaxe

2007-05-18T00:37:31Z

Currently, there are rather draconian restrictions on the strings accepted by the pickaxe search, which degrades its usefulness for digging in code significantly. This patch remedies mentioned limitation. Signed-off-by: Petr Baudis Signed-off-by: Junio C Hamano

gitweb: Add support for grep searches

2007-05-18T00:37:31Z

The 'grep' type of search greps the currently selected tree for given regexp and shows the results in a fancy table with links into blob view. The number of shown matches is limited to 1000 and the whole feature can be turned off (grepping linux-2.6.git already makes repo.or.cz a bit unhappy). This second revision makes it in documentation explicit that grep accepts regexps, and makes grep accept extended regexps instead of basic regexps. Signed-off-by: Petr Baudis Signed-off-by: Junio C Hamano

gitweb: Normalize searchbar font size

2007-05-18T00:37:30Z

Currently, searchbar font was as big as the page heading font, because font-size was made relative - but to the parent element, which was for some reason indeed page_header. Since that seems to be illogical to me, I just moved the div.search outside of div.page_header. I'm no CSS/DOM expert but no adverse effects were observed by me. Signed-off-by: Petr Baudis Signed-off-by: Junio C Hamano

gitweb: Fix error in git_patchset_body for deletion in merge commit

2007-05-18T00:35:33Z

Checking if $diffinfo->{'status'} is equal 'D' is no longer the way to check if the file was deleted in result. For merge commits $diffinfo->{'status'} is reference to array of statuses for each parent. Use the fact that $diffinfo->{'to_id'} is all zeros as sign that file was deleted in result. Signed-off-by: Jakub Narebski Signed-off-by: Junio C Hamano

gitweb: fix another use of undefined value

2007-05-17T04:04:16Z

Pasky and Jakub competed fixing these and in the confusion this ended up not being covered. Signed-off-by: Junio C Hamano

gitweb: Empty patch for merge means trivial merge, not no differences

2007-05-16T23:13:42Z

Earlier commit 4280cde95fa4e3fb012eb6d0c239a7777baaf60c made gitweb show "No differences found" message for empty diff, for the HTML output. But for merge commits, either -c format we use or --cc format, empty diff doesn't mean no differences, but trivial merge. Show "Trivial merge" message instead of "No differences found" for merges. While at it reword conditional in the code for easier reading. Signed-off-by: Jakub Narebski Signed-off-by: Junio C Hamano

gitweb: Separate search regexp from search text

2007-05-16T19:40:06Z

Separate search text, which is saved in $searchtext global variable, and is used in links, as default value for the textfield in search form, and for pickaxe search, from search regexp, which is saved in $search_regexp global variable, and is used as parameter to --grep, --committer or --author options to git-rev-list, and for searching commit body in gitweb. For now $search_regexp is unconditionallt equal to quotemeta($searchtext), meaning that we always search for fixed string. This fixes bug where 'next page' links for 'search' view didn't work for searchtext containing quotable characters, like `@'. Signed-off-by: Jakub Narebski Signed-off-by: Junio C Hamano

gitweb: Do not use absolute font sizes

2007-05-16T19:40:06Z

David Kågedal proposed that gitweb should explicitely request being somewhat smaller than normal, because it has good use for long lines. However gitweb presents a table with several columns, so having wider line is OK for it. Therefore explicit 'font-size: small' would make sense. Apparently many people on the list seem to agree with him. Signed-off-by: Junio C Hamano