git/http-walker.c, branch v2.10.1

http-walker: reduce O(n) ops with doubly-linked list

2016-07-12T22:17:42Z

Using the a Linux-kernel-derived doubly-linked list implementation from the Userspace RCU library allows us to enqueue and delete items from the object request queue in constant time. This change reduces enqueue times in the prefetch() function where object request queue could grow to several thousand objects. I left out the list_for_each_entry* family macros from list.h which relied on the __typeof__ operator as we support platforms without it. Thus, list_entry (aka "container_of") needs to be called explicitly inside macro-wrapped for loops. The downside is this costs us an additional pointer per object request, but this is offset by reduced overhead on queue operations leading to improved performance and shorter queue depths. Signed-off-by: Eric Wong Signed-off-by: Junio C Hamano

http: avoid disconnecting on 404s for loose objects

2016-07-12T22:17:42Z

404s are common when fetching loose objects on static HTTP servers, and reestablishing a connection for every single 404 adds additional latency. Signed-off-by: Eric Wong Signed-off-by: Junio C Hamano

http-walker: remove unused parameter from fetch_object

2016-07-12T22:17:41Z

This parameter has not been used since commit 1d389ab65dc6 ("Add support for parallel HTTP transfers") back in 2005 Signed-off-by: Eric Wong Signed-off-by: Junio C Hamano

http-walker: store url in a strbuf

2015-09-25T17:18:18Z

We do an unchecked sprintf directly into our url buffer. This doesn't overflow because we know that it was sized for "$base/objects/info/http-alternates", and we are writing "$base/objects/info/alternates", which must be smaller. But that is not immediately obvious to a reader who is looking for buffer overflows. Let's switch to a strbuf, so that we do not have to think about this issue at all. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

http-walker: simplify process_alternates_response() using strbuf

2014-09-02T17:57:14Z

Use strbuf to build the new base, which takes care of allocations and the terminating NUL character automatically. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

use xstrfmt to replace xmalloc + sprintf

2014-06-19T22:20:54Z

This is one line shorter, and makes sure the length in the malloc and sprintf steps match. These conversions are very straightforward; we can drop the malloc entirely, and replace the sprintf with xstrfmt. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

use xstrdup instead of xmalloc + strcpy

2014-06-19T22:20:53Z

This is one line shorter, and makes sure the length in the malloc and copy steps match. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

Rename static function fetch_pack() to http_fetch_pack()

2012-09-12T18:46:31Z

Avoid confusion with the non-static function of the same name from fetch-pack.h. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano

http: make curl callbacks match contracts from curl header

2011-05-04T20:30:28Z

Yes, these don't match perfectly with the void* first parameter of the fread/fwrite in the standard library, but they do match the curl expected method signature. This is needed when a refactor passes a curl_write_callback around, which would otherwise give incorrect parameter warnings. Signed-off-by: Dan McGee Signed-off-by: Junio C Hamano

standardize brace placement in struct definitions

2011-03-16T19:49:02Z

In a struct definitions, unlike functions, the prevailing style is for the opening brace to go on the same line as the struct name, like so: struct foo { int bar; char *baz; }; Indeed, grepping for 'struct [a-z_]* {$' yields about 5 times as many matches as 'struct [a-z_]*$'. Linus sayeth: Heretic people all over the world have claimed that this inconsistency is ... well ... inconsistent, but all right-thinking people know that (a) K&R are _right_ and (b) K&R are right. Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano