git/run-command.c, branch v1.6.2

Merge branch 'jk/maint-cleanup-after-exec-failure'

2009-02-03T08:26:12Z

* jk/maint-cleanup-after-exec-failure: git: use run_command() to execute dashed externals run_command(): help callers distinguish errors run_command(): handle missing command errors more gracefully git: s/run_command/run_builtin/

run_command(): handle missing command errors more gracefully

2009-01-28T22:08:57Z

When run_command() was asked to run a non-existant command, its behavior varied depending on the platform: - on POSIX systems, we would fork, and then after the execvp call failed, we could call die(), which prints a message to stderr and exits with code 128. - on Windows, we do a PATH lookup, realize the program isn't there, and then return ERR_RUN_COMMAND_FORK The goal of this patch is to make it clear to callers that the specific error was a missing command. To do this, we will return the error code ERR_RUN_COMMAND_EXEC, which is already defined in run-command.h, checked for in several places, but never actually gets set. The new behavior is: - on POSIX systems, we exit the forked process with code 127 (the same as the shell uses to report missing commands). The parent process recognizes this code and returns an EXEC error. The stderr message is silenced, since the caller may be speculatively trying to run a command. Instead, we use trace_printf so that somebody interested in debugging can see the error that occured. - on Windows, we check errno, which is already set correctly by mingw_spawnvpe, and report an EXEC error instead of a FORK error Thus it is safe to speculatively run a command: int r = run_command_v_opt(argv, 0); if (r == -ERR_RUN_COMMAND_EXEC) /* oops, it wasn't found; try something else */ else /* we failed for some other reason, error is in r */ Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

run_hook(): allow more than 9 hook arguments

2009-01-18T01:57:15Z

This is done using the ALLOC_GROW macro. Signed-off-by: Stephan Beyer Signed-off-by: Junio C Hamano

run_hook(): check the executability of the hook before filling argv

2009-01-18T01:16:44Z

Signed-off-by: Stephan Beyer Signed-off-by: Junio C Hamano

Move run_hook() from builtin-commit.c into run-command.c (libgit)

2009-01-18T01:16:24Z

A function that runs a hook is used in several Git commands. builtin-commit.c has the one that is most general for cases without piping. The one in builtin-gc.c prints some useful warnings. This patch moves a merged version of these variants into libgit and lets the other builtins use this libified run_hook(). The run_hook() function used in receive-pack.c feeds the standard input of the pre-receive or post-receive hooks. This function is renamed to run_receive_hook() because the libified run_hook() cannot handle this. Mentored-by: Daniel Barkalow Mentored-by: Christian Couder Signed-off-by: Stephan Beyer Signed-off-by: Junio C Hamano

run-command.c: remove run_command_v_opt_cd()

2008-10-03T01:02:44Z

This function is not used anywhere. Johannes Sixt : > Future callers can use run_command_v_opt_cd_env() instead. Signed-off-by: Nanako Shiraishi Signed-off-by: Shawn O. Pearce

Merge branch 'jk/pager-swap'

2008-08-20T04:42:55Z

* jk/pager-swap: spawn pager via run_command interface run-command: add pre-exec callback

Add output flushing before fork()

2008-08-05T04:46:42Z

This adds fflush(NULL) before fork() in start_command(), to keep the generic interface safe. A remaining use of fork() with no flushing is in a comment in show_tree(). Rewrite that comment to use start_command(). Signed-off-by: Anders Melchiorsen Signed-off-by: Junio C Hamano

Flush output in start_async

2008-08-04T00:55:40Z

This prevents double output in case stdout is redirected. Signed-off-by: Anders Melchiorsen Signed-off-by: Junio C Hamano

run-command (Windows): Run dashless "git "

2008-07-29T06:02:11Z

We prefer running the dashless form, and POSIX side already does so; we should use it in MinGW's start_command(), too. Signed-off-by: Steffen Prohaska Acked-by: Johannes Sixt Signed-off-by: Junio C Hamano