git/trace2, branch v2.24.2

trace2: write discard message to sentinel files

2019-10-05T08:53:51Z

Add a new "discard" event type for trace2 event destinations. When the trace2 file count check creates a sentinel file, it will include the normal trace2 output in the sentinel, along with this new discard event. Writing this message into the sentinel file is useful for tracking how often the file count check triggers in practice. Bump up the event format version since we've added a new event type. Signed-off-by: Josh Steadmon Signed-off-by: Junio C Hamano

trace2: discard new traces if target directory has too many files

2019-10-05T08:53:51Z

trace2 can write files into a target directory. With heavy usage, this directory can fill up with files, causing difficulty for trace-processing systems. This patch adds a config option (trace2.maxFiles) to set a maximum number of files that trace2 will write to a target directory. The following behavior is enabled when the maxFiles is set to a positive integer: When trace2 would write a file to a target directory, first check whether or not the traces should be discarded. Traces should be discarded if: * there is a sentinel file declaring that there are too many files * OR, the number of files exceeds trace2.maxFiles. In the latter case, we create a sentinel file named git-trace2-discard to speed up future checks. The assumption is that a separate trace-processing system is dealing with the generated traces; once it processes and removes the sentinel file, it should be safe to generate new trace files again. The default value for trace2.maxFiles is zero, which disables the file count check. The config can also be overridden with a new environment variable: GIT_TRACE2_MAX_FILES. Signed-off-by: Josh Steadmon Signed-off-by: Junio C Hamano

Merge branch 'jh/trace2-pretty-output'

2019-09-30T04:19:31Z

Output from trace2 subsystem is formatted more prettily now. * jh/trace2-pretty-output: trace2: cleanup whitespace in perf format trace2: cleanup whitespace in normal format quote: add sq_append_quote_argv_pretty() trace2: trim trailing whitespace in normal format error message trace2: remove dead code in maybe_add_string_va() trace2: trim whitespace in region messages in perf target format trace2: cleanup column alignment in perf target format

Merge branch 'rs/trace2-dst-warning'

2019-09-30T04:19:24Z

Code cleanup. * rs/trace2-dst-warning: trace2: use warning() directly in tr2_dst_malformed_warning()

trace2: use warning() directly in tr2_dst_malformed_warning()

2019-08-26T18:34:23Z

Let warning() format the message instead of using an intermediate strbuf for that. This is shorter, easier to read and avoids an allocation. Signed-off-by: René Scharfe Signed-off-by: Junio C Hamano

trace2: cleanup whitespace in perf format

2019-08-09T17:48:02Z

Make use of new sq_append_quote_argv_pretty() to normalize how we handle leading whitespace in perf format messages. Signed-off-by: Jeff Hostetler Signed-off-by: Junio C Hamano

trace2: cleanup whitespace in normal format

2019-08-09T17:48:02Z

Make use of new sq_append_quote_argv_pretty() to normalize how we handle leading whitespace in normal format messages. Signed-off-by: Jeff Hostetler Signed-off-by: Junio C Hamano

trace2: trim trailing whitespace in normal format error message

2019-08-08T17:39:44Z

Avoid creating unnecessary trailing whitespace in normal target format error messages when the message is omitted. Signed-off-by: Jeff Hostetler Signed-off-by: Junio C Hamano

trace2: remove dead code in maybe_add_string_va()

2019-08-08T17:39:44Z

Remove an unnecessary "if" block in maybe_add_string_va(). Commit "ad006fe419e trace2: NULL is not allowed for va_list" changed "if (fmt && *fmt && ap)" to just "if (fmt && *fmt)" because it isn't safe to treat 'ap' as a pointer. This made the "if" block following it unnecessary. Signed-off-by: Jeff Hostetler Signed-off-by: Junio C Hamano

trace2: trim whitespace in region messages in perf target format

2019-08-08T17:39:44Z

Avoid unecessary trailing whitespace in "region_enter" and "region_leave" messages in perf target format. Signed-off-by: Jeff Hostetler Signed-off-by: Junio C Hamano