aboutsummaryrefslogtreecommitdiffstats
path: root/commit.c
diff options
context:
space:
mode:
authorJohannes Schindelin <johannes.schindelin@gmx.de>2022-06-15 23:35:39 +0000
committerJunio C Hamano <gitster@pobox.com>2022-06-16 13:22:03 -0700
commitf53559227ccb600f4fdd1bfe08e1164a5aed60b5 (patch)
tree09c614f7823f06f921e5eba4035f26eff86b6fa2 /commit.c
parentfsmonitor: avoid memory leak in `fsm_settings__get_incompatible_msg()` (diff)
downloadgit-f53559227ccb600f4fdd1bfe08e1164a5aed60b5.tar.gz
git-f53559227ccb600f4fdd1bfe08e1164a5aed60b5.zip
submodule-config: avoid memory leak
In 961b130d20c9 (branch: add --recurse-submodules option for branch creation, 2022-01-28), a funny pattern was introduced where first some struct is `xmalloc()`ed, then we resize an array whose element type is the same struct, and then the first struct's contents are copied into the last element of that array. Crucially, the `xmalloc()`ed memory never gets released. Let's avoid that memory leak and that memory allocation dance altogether by first reallocating the array, then using a pointer to the last array element to go forward. Reported by Coverity. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'commit.c')
0 files changed, 0 insertions, 0 deletions