aboutsummaryrefslogtreecommitdiffstats
path: root/git-gui/lib/commit.tcl
diff options
context:
space:
mode:
Diffstat (limited to 'git-gui/lib/commit.tcl')
-rw-r--r--git-gui/lib/commit.tcl14
1 files changed, 7 insertions, 7 deletions
diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl
index 11379f8ad3..bb6056d0ad 100644
--- a/git-gui/lib/commit.tcl
+++ b/git-gui/lib/commit.tcl
@@ -27,7 +27,7 @@ You are currently in the middle of a merge that has not been fully completed. Y
if {[catch {
set name ""
set email ""
- set fd [git_read cat-file commit $curHEAD]
+ set fd [git_read [list cat-file commit $curHEAD]]
fconfigure $fd -encoding binary -translation lf
# By default commits are assumed to be in utf-8
set enc utf-8
@@ -225,7 +225,7 @@ A good commit message has the following format:
# -- Build the message file.
#
set msg_p [gitdir GITGUI_EDITMSG]
- set msg_wt [open $msg_p w]
+ set msg_wt [safe_open_file $msg_p w]
fconfigure $msg_wt -translation lf
setup_commit_encoding $msg_wt
puts $msg_wt $msg
@@ -325,7 +325,7 @@ proc commit_commitmsg_wait {fd_ph curHEAD msg_p} {
proc commit_writetree {curHEAD msg_p} {
ui_status [mc "Committing changes..."]
- set fd_wt [git_read write-tree]
+ set fd_wt [git_read [list write-tree]]
fileevent $fd_wt readable \
[list commit_committree $fd_wt $curHEAD $msg_p]
}
@@ -350,7 +350,7 @@ proc commit_committree {fd_wt curHEAD msg_p} {
# -- Verify this wasn't an empty change.
#
if {$commit_type eq {normal}} {
- set fd_ot [git_read cat-file commit $PARENT]
+ set fd_ot [git_read [list cat-file commit $PARENT]]
fconfigure $fd_ot -encoding binary -translation lf
set old_tree [gets $fd_ot]
close $fd_ot
@@ -388,8 +388,8 @@ A rescan will be automatically started now.
foreach p [concat $PARENT $MERGE_HEAD] {
lappend cmd -p $p
}
- lappend cmd <$msg_p
- if {[catch {set cmt_id [eval git $cmd]} err]} {
+ set msgtxt [list <$msg_p]
+ if {[catch {set cmt_id [git_redir $cmd $msgtxt]} err]} {
catch {file delete $msg_p}
error_popup [strcat [mc "commit-tree failed:"] "\n\n$err"]
ui_status [mc "Commit failed."]
@@ -409,7 +409,7 @@ A rescan will be automatically started now.
if {$commit_type ne {normal}} {
append reflogm " ($commit_type)"
}
- set msg_fd [open $msg_p r]
+ set msg_fd [safe_open_file $msg_p r]
setup_commit_encoding $msg_fd 1
gets $msg_fd subject
close $msg_fd
1/+1 2008-09-29Use strchrnul() instead of strchr() plus manual workaroundJohan Herland1-3/+1 2008-09-29Use remove_path from dir.c instead of own implementationAlex Riesen3-49/+5 2008-09-29Add remove_path: a function to remove as much as possible of a pathAlex Riesen2-0/+23 2008-09-29git-submodule: Fix "Unable to checkout" for the initial 'update'Ping Yin1-2/+7 2008-09-29Clarify how the user can satisfy stash's 'dirty state' check.Stephen Haberman1-1/+1 2008-09-26Remove empty directories in recursive mergeAlex Riesen2-3/+12 2008-09-26Documentation: clarify the details of overriding LESS via core.pagerChris Frey1-2/+11 2008-09-25Update release notes for 1.6.0.3Shawn O. Pearce1-1/+17 2008-09-25checkout: Do not show local changes when in quiet modeJonas Fonseca1-1/+1 2008-09-24for-each-ref: Fix --format=%(subject) for log message without newlinesJohan Herland1-2/+2 2008-09-24git-stash.sh: don't default to refs/stash if invalid ref suppliedBrandon Casey1-2/+15 2008-09-24maint: check return of split_cmdline to avoid bad config stringsDeskin Miller3-0/+14 2008-09-23builtin-prune.c: prune temporary packs in <object_dir>/pack directoryBrandon Casey1-10/+12 2008-09-22t4018-diff-funcname: test syntax of builtin xfuncname patternsBrandon Casey1-0/+11 2008-09-22Do not perform cross-directory renames when creating packsPetr Baudis4-5/+5 2008-09-22Use dashless git commands in setgitperms.perlTodd Zullinger1-2/+2 2008-09-22git-remote: do not use user input in a printf format stringJohannes Sixt1-10/+8 2008-09-22make "git remote" report multiple URLsMichael J Gruber1-8/+15 2008-09-20diff hunk pattern: fix misconverted "\{" tex macro introducersJunio C Hamano1-2/+2 2008-09-19diff: use extended regexp to find hunk headersJunio C Hamano1-14/+17 2008-09-19Start draft release notes for 1.6.0.3Junio C Hamano2-1/+30 2008-09-19git-repack uses --no-repack-object, not --no-repack-delta.Mikael Magnusson2-2/+2 2008-09-19Typo "bogos" in format-patch error message.Mikael Magnusson1-1/+1 2008-09-19builtin-clone: fix typoFabrizio Chiarello1-1/+1 2008-09-19Bust the ghost of long-defunct diffcore-pathspec.Yann Dirson2-34/+22 2008-09-19completion: git commit should list --interactiveEric Raible1-1/+1 2008-09-18diff.*.xfuncname which uses "extended" regex's for hunk header selectionBrandon Casey3-3/+8 2008-09-18diff.c: associate a flag with each pattern and use it for compiling regexBrandon Casey3-12/+15 2008-09-18diff.c: return pattern entry pointer rather than just the hunk header patternBrandon Casey1-27/+28 2008-09-18sha1_file: link() returns -1 on failure, not errnoThomas Rast1-1/+3 2008-09-18Make git archive respect core.autocrlf when creating zip format archivesCharles Bailey2-1/+3