From 8b3f33ef11821a6a030f789eeb0b3af01469901e Mon Sep 17 00:00:00 2001 From: Mischa POSLAWSKY Date: Sat, 17 Aug 2019 23:51:07 +0200 Subject: ref-filter: initialize empty name or email fields Formatting $(taggername) on headerless tags such as v0.99 in Git causes a SIGABRT with error "munmap_chunk(): invalid pointer", because of an oversight in commit f0062d3b74 (ref-filter: free item->value and item->value->s, 2018-10-19). Signed-off-by: Mischa POSLAWSKY Signed-off-by: Junio C Hamano --- ref-filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'ref-filter.c') diff --git a/ref-filter.c b/ref-filter.c index 5de616befe..3116f74225 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -976,7 +976,7 @@ static const char *copy_name(const char *buf) if (!strncmp(cp, " <", 2)) return xmemdupz(buf, cp - buf); } - return ""; + return xstrdup(""); } static const char *copy_email(const char *buf) @@ -984,10 +984,10 @@ static const char *copy_email(const char *buf) const char *email = strchr(buf, '<'); const char *eoemail; if (!email) - return ""; + return xstrdup(""); eoemail = strchr(email, '>'); if (!eoemail) - return ""; + return xstrdup(""); return xmemdupz(email, eoemail + 1 - email); } -- cgit v1.2.3