diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2023-04-29 13:24:18 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:10:00 -0400 |
| commit | 174f930b8e1cad3915819a46bb20da214f68f2b5 (patch) | |
| tree | 413eb321e97d3184f68716c8df8a4eef9c1e5b44 /fs/bcachefs/reflink.h | |
| parent | bcachefs: Converting to typed bkeys is now allowed for err, null ptrs (diff) | |
| download | linux-174f930b8e1cad3915819a46bb20da214f68f2b5.tar.gz linux-174f930b8e1cad3915819a46bb20da214f68f2b5.zip | |
bcachefs: bkey_ops.min_val_size
This adds a new field to bkey_ops for the minimum size of the value,
which standardizes that check and also enforces the new rule (previously
done somewhat ad-hoc) that we can extend value types by adding new
fields on to the end.
To make that work we do _not_ initialize min_val_size with sizeof,
instead we initialize it to the size of the first version of those
values.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/reflink.h')
| -rw-r--r-- | fs/bcachefs/reflink.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/bcachefs/reflink.h b/fs/bcachefs/reflink.h index 2391037c2ece..ba400188f5be 100644 --- a/fs/bcachefs/reflink.h +++ b/fs/bcachefs/reflink.h @@ -14,6 +14,7 @@ bool bch2_reflink_p_merge(struct bch_fs *, struct bkey_s, struct bkey_s_c); .key_merge = bch2_reflink_p_merge, \ .trans_trigger = bch2_trans_mark_reflink_p, \ .atomic_trigger = bch2_mark_reflink_p, \ + .min_val_size = 16, \ }) int bch2_reflink_v_invalid(const struct bch_fs *, struct bkey_s_c, @@ -29,6 +30,7 @@ int bch2_trans_mark_reflink_v(struct btree_trans *, enum btree_id, unsigned, .swab = bch2_ptr_swab, \ .trans_trigger = bch2_trans_mark_reflink_v, \ .atomic_trigger = bch2_mark_extent, \ + .min_val_size = 8, \ }) int bch2_indirect_inline_data_invalid(const struct bch_fs *, struct bkey_s_c, @@ -44,6 +46,7 @@ int bch2_trans_mark_indirect_inline_data(struct btree_trans *, .key_invalid = bch2_indirect_inline_data_invalid, \ .val_to_text = bch2_indirect_inline_data_to_text, \ .trans_trigger = bch2_trans_mark_indirect_inline_data, \ + .min_val_size = 8, \ }) static inline const __le64 *bkey_refcount_c(struct bkey_s_c k) |