diff options
| author | Zhengxu Zhang <zhengxu.zhang@unisoc.com> | 2025-06-19 09:33:31 +0800 |
|---|---|---|
| committer | Namjae Jeon <linkinjeon@kernel.org> | 2025-08-01 08:34:17 +0900 |
| commit | 2f2d42a17b5a6711378d39df74f1f69a831c5d4e (patch) | |
| tree | 45b5140da0ec228d63f4ef047aa689d06445d887 /fs/exfat | |
| parent | Merge tag 'mtd/for-6.17' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd... (diff) | |
| download | linux-2f2d42a17b5a6711378d39df74f1f69a831c5d4e.tar.gz linux-2f2d42a17b5a6711378d39df74f1f69a831c5d4e.zip | |
exfat: fdatasync flag should be same like generic_write_sync()
Test: androbench by default setting, use 64GB sdcard.
the random write speed:
without this patch 3.5MB/s
with this patch 7MB/s
After patch "11a347fb6cef", the random write speed decreased significantly.
the .write_iter() interface had been modified, and check the differences
with generic_file_write_iter(), when calling generic_write_sync() and
exfat_file_write_iter() to call vfs_fsync_range(), the fdatasync flag is
wrong, and make not use the fdatasync mode, and make random write speed
decreased. So use generic_write_sync() instead of vfs_fsync_range().
Fixes: 11a347fb6cef ("exfat: change to get file size from DataLength")
Signed-off-by: Zhengxu Zhang <zhengxu.zhang@unisoc.com>
Acked-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Diffstat (limited to 'fs/exfat')
| -rw-r--r-- | fs/exfat/file.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/exfat/file.c b/fs/exfat/file.c index 6b82497572b4..538d2b6ac2ec 100644 --- a/fs/exfat/file.c +++ b/fs/exfat/file.c @@ -622,9 +622,8 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter) if (pos > valid_size) pos = valid_size; - if (iocb_is_dsync(iocb) && iocb->ki_pos > pos) { - ssize_t err = vfs_fsync_range(file, pos, iocb->ki_pos - 1, - iocb->ki_flags & IOCB_SYNC); + if (iocb->ki_pos > pos) { + ssize_t err = generic_write_sync(iocb, iocb->ki_pos - pos); if (err < 0) return err; } |