summaryrefslogtreecommitdiffstats
path: root/fs/iomap
diff options
context:
space:
mode:
authorBrian Foster <bfoster@redhat.com>2025-02-24 09:47:57 -0500
committerChristian Brauner <brauner@kernel.org>2025-02-26 09:42:37 +0100
commitd79c9cc512973ef6583c3bfc0b343f9d312d85b3 (patch)
tree1da287f0d733f153d1e494daca38b37803fb796f /fs/iomap
parentiomap: rename iomap_iter processed field to status (diff)
downloadlinux-d79c9cc512973ef6583c3bfc0b343f9d312d85b3.tar.gz
linux-d79c9cc512973ef6583c3bfc0b343f9d312d85b3.zip
iomap: introduce a full map advance helper
Various iomap_iter_advance() calls advance by the full mapping length and thus have no need for the current length input or post-advance remaining length output from the standard advance function. Add an iomap_iter_advance_full() helper to clean up these cases. Signed-off-by: Brian Foster <bfoster@redhat.com> Link: https://lore.kernel.org/r/20250224144757.237706-13-bfoster@redhat.com Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/iomap')
-rw-r--r--fs/iomap/buffered-io.c3
-rw-r--r--fs/iomap/fiemap.c3
-rw-r--r--fs/iomap/swapfile.c4
3 files changed, 3 insertions, 7 deletions
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index cdb0fedcf3d2..ea5e32d810d5 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -1433,8 +1433,7 @@ iomap_zero_range(struct inode *inode, loff_t pos, loff_t len, bool *did_zero,
range_dirty = false;
status = iomap_zero_iter_flush_and_stale(&iter);
} else {
- u64 length = iomap_length(&iter);
- status = iomap_iter_advance(&iter, &length);
+ status = iomap_iter_advance_full(&iter);
}
iter.status = status;
continue;
diff --git a/fs/iomap/fiemap.c b/fs/iomap/fiemap.c
index 6776b800bde7..80675c42e94e 100644
--- a/fs/iomap/fiemap.c
+++ b/fs/iomap/fiemap.c
@@ -42,7 +42,6 @@ static int iomap_to_fiemap(struct fiemap_extent_info *fi,
static int iomap_fiemap_iter(struct iomap_iter *iter,
struct fiemap_extent_info *fi, struct iomap *prev)
{
- u64 length = iomap_length(iter);
int ret;
if (iter->iomap.type == IOMAP_HOLE)
@@ -56,7 +55,7 @@ static int iomap_fiemap_iter(struct iomap_iter *iter,
return 0;
advance:
- return iomap_iter_advance(iter, &length);
+ return iomap_iter_advance_full(iter);
}
int iomap_fiemap(struct inode *inode, struct fiemap_extent_info *fi,
diff --git a/fs/iomap/swapfile.c b/fs/iomap/swapfile.c
index 9ea185e58ca7..c1a762c10ce4 100644
--- a/fs/iomap/swapfile.c
+++ b/fs/iomap/swapfile.c
@@ -97,8 +97,6 @@ static int iomap_swapfile_fail(struct iomap_swapfile_info *isi, const char *str)
static int iomap_swapfile_iter(struct iomap_iter *iter,
struct iomap *iomap, struct iomap_swapfile_info *isi)
{
- u64 length = iomap_length(iter);
-
switch (iomap->type) {
case IOMAP_MAPPED:
case IOMAP_UNWRITTEN:
@@ -135,7 +133,7 @@ static int iomap_swapfile_iter(struct iomap_iter *iter,
memcpy(&isi->iomap, iomap, sizeof(isi->iomap));
}
- return iomap_iter_advance(iter, &length);
+ return iomap_iter_advance_full(iter);
}
/*