diff options
| author | Christian Brauner <brauner@kernel.org> | 2025-04-11 15:22:44 +0200 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2025-04-12 14:04:29 +0200 |
| commit | 35c9701ea717dc548f1fab5bfa286be98c1bade8 (patch) | |
| tree | d9b327d266b3912bc4715c6bef457013fd7d6b3e /kernel/pid.c | |
| parent | Merge patch series "pidfd: improve uapi when task isn't found" (diff) | |
| download | linux-35c9701ea717dc548f1fab5bfa286be98c1bade8.tar.gz linux-35c9701ea717dc548f1fab5bfa286be98c1bade8.zip | |
exit: move wake_up_all() pidfd waiters into __unhash_process()
Move the pidfd notification out of __change_pid() and into
__unhash_process(). The only valid call to __change_pid() with a NULL
argument and PIDTYPE_PID is from __unhash_process(). This is a lot more
obvious than calling it from __change_pid().
Link: https://lore.kernel.org/20250411-work-pidfs-enoent-v2-1-60b2d3bb545f@kernel.org
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'kernel/pid.c')
| -rw-r--r-- | kernel/pid.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/kernel/pid.c b/kernel/pid.c index 4ac2ce46817f..26f1e136f017 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@ -359,11 +359,6 @@ static void __change_pid(struct pid **pids, struct task_struct *task, hlist_del_rcu(&task->pid_links[type]); *pid_ptr = new; - if (type == PIDTYPE_PID) { - WARN_ON_ONCE(pid_has_task(pid, PIDTYPE_PID)); - wake_up_all(&pid->wait_pidfd); - } - for (tmp = PIDTYPE_MAX; --tmp >= 0; ) if (pid_has_task(pid, tmp)) return; |