diff options
| author | Junio C Hamano <gitster@pobox.com> | 2024-01-16 10:11:57 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-01-16 10:11:57 -0800 |
| commit | 6484eb9a97fe3cd81a2d5711183b93494e6ddefa (patch) | |
| tree | 47b685da95e65634ad2a448c1ccc939e20fb22d1 | |
| parent | Merge branch 'ps/refstorage-extension' (diff) | |
| parent | sideband.c: remove redundant 'NEEDSWORK' tag (diff) | |
| download | git-6484eb9a97fe3cd81a2d5711183b93494e6ddefa.tar.gz git-6484eb9a97fe3cd81a2d5711183b93494e6ddefa.zip | |
Merge branch 'cp/sideband-array-index-comment-fix'
In-code comment fix.
* cp/sideband-array-index-comment-fix:
sideband.c: remove redundant 'NEEDSWORK' tag
| -rw-r--r-- | sideband.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sideband.c b/sideband.c index 6cbfd391c4..266a67342b 100644 --- a/sideband.c +++ b/sideband.c @@ -69,7 +69,10 @@ void list_config_color_sideband_slots(struct string_list *list, const char *pref * of the line. This should be called for a single line only, which is * passed as the first N characters of the SRC array. * - * NEEDSWORK: use "size_t n" instead for clarity. + * It is fine to use "int n" here instead of "size_t n" as all calls to this + * function pass an 'int' parameter. Additionally, the buffer involved in + * storing these 'int' values takes input from a packet via the pkt-line + * interface, which is capable of transferring only 64kB at a time. */ static void maybe_colorize_sideband(struct strbuf *dest, const char *src, int n) { |