diff options
| author | Jan Mazur <mzr@fb.com> | 2025-06-04 17:11:21 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2025-06-04 13:19:47 -0700 |
| commit | efb61591ee482fd9ec0ebabffef1bed5b71fdfab (patch) | |
| tree | 08d38bba10e4453560709cde20109333228ed624 | |
| parent | Git 2.40.4 (diff) | |
| download | git-efb61591ee482fd9ec0ebabffef1bed5b71fdfab.tar.gz git-efb61591ee482fd9ec0ebabffef1bed5b71fdfab.zip | |
bundle-uri: send debug output to given FILE * stream
d796cedb (bundle-uri: unit test "key=value" parsing, 2022-10-12)
introduced the print_bundle_list() function, which takes a "FILE
*fp" to write the output to. Later with c93c3d2f (bundle-uri:
parse bundle.heuristic=creationToken, 2023-01-31) the function
started showing additional information, which is always written
to the standard output stream.
It does not look like a deliberate decision to do so, and it
does not hurt, as all callers of the function passes stdout to
it.
We could change the function not to take fp and always write to
the standard output to simplify, but let's use the FILE *fp
provided by the caller consistently to write out output.
Signed-off-by: Jan Mazur <mzr@meta.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | bundle-uri.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bundle-uri.c b/bundle-uri.c index 8a3c39ce57..72e70c51fd 100644 --- a/bundle-uri.c +++ b/bundle-uri.c @@ -115,7 +115,7 @@ void print_bundle_list(FILE *fp, struct bundle_list *list) int i; for (i = 0; i < BUNDLE_HEURISTIC__COUNT; i++) { if (heuristics[i].heuristic == list->heuristic) { - printf("\theuristic = %s\n", + fprintf(fp, "\theuristic = %s\n", heuristics[list->heuristic].name); break; } |