diff options
| author | Jeff King <peff@peff.net> | 2023-01-06 06:05:00 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-01-06 21:50:09 +0900 |
| commit | f034bb1cad862a678030cdf0ae833636f9d7dbca (patch) | |
| tree | fd9391b196cb39e230af0c6699f8ce4bb392a05f /builtin/commit-tree.c | |
| parent | diff: clean up external-diff argv setup (diff) | |
| download | git-f034bb1cad862a678030cdf0ae833636f9d7dbca.tar.gz git-f034bb1cad862a678030cdf0ae833636f9d7dbca.zip | |
diff: drop "name" parameter from prepare_temp_file()
The prepare_temp_file() function takes a diff_filespec as well as a
filename. But it is almost certainly an error to pass in a name that
isn't the filespec's "path" parameter, since that is the only thing that
reliably tells us how to find the content (and indeed, this was the
source of a recently-fixed bug).
So let's drop the redundant "name" parameter and just use one->path
throughout the function. This simplifies the interface a little bit, and
makes it impossible for calling code to get it wrong.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit-tree.c')
0 files changed, 0 insertions, 0 deletions
