diff options
| author | Elijah Newren <newren@gmail.com> | 2022-02-02 02:37:30 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-02-02 10:02:27 -0800 |
| commit | 35f6967161860cb5c067e961b7283e8389ff0726 (patch) | |
| tree | a14a32a6bcadc57722e27ce66b8e51e303ceab01 /builtin/commit.c | |
| parent | log: clean unneeded objects during `log --remerge-diff` (diff) | |
| download | git-35f6967161860cb5c067e961b7283e8389ff0726.tar.gz git-35f6967161860cb5c067e961b7283e8389ff0726.zip | |
ll-merge: make callers responsible for showing warnings
Since some callers may want to send warning messages to somewhere other
than stdout/stderr, stop printing "warning: Cannot merge binary files"
from ll-merge and instead modify the return status of ll_merge() to
indicate when a merge of binary files has occurred. Message printing
probably does not belong in a "low-level merge" anyway.
This commit continues printing the message as-is, just from the callers
instead of within ll_merge(). Future changes will start handling the
message differently in the merge-ort codepath.
There was one special case here: the callers in rerere.c do NOT check
for and print such a message; since those code paths explicitly skip
over binary files, there is no reason to check for a return status of
LL_MERGE_BINARY_CONFLICT or print the related message.
Note that my methodology included first modifying ll_merge() to return
a struct, so that the compiler would catch all the callers for me and
ensure I had modified all of them. After modifying all of them, I then
changed the struct to an enum.
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit.c')
0 files changed, 0 insertions, 0 deletions
