diff options
| author | Jonathan Nieder <jrnieder@gmail.com> | 2014-08-28 16:42:37 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-10-15 10:47:26 -0700 |
| commit | 5a603b046351894a3c892d5bd6948fcee1bee5ab (patch) | |
| tree | 38074392c2d451c01d39eef81ad5fc26953df735 /builtin/commit.c | |
| parent | remote rm/prune: print a message when writing packed-refs fails (diff) | |
| download | git-5a603b046351894a3c892d5bd6948fcee1bee5ab.tar.gz git-5a603b046351894a3c892d5bd6948fcee1bee5ab.zip | |
refs.c: do not permit err == NULL
Some functions that take a strbuf argument to append an error treat
!err as an indication that the message should be suppressed (e.g.,
ref_update_reject_duplicates). Others write the message to stderr on
!err (e.g., repack_without_refs). Others crash (e.g.,
ref_transaction_update).
Some of these behaviors are for historical reasons and others were
accidents. Luckily no callers pass err == NULL any more. Simplify
by consistently requiring the strbuf argument.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Reviewed-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit.c')
0 files changed, 0 insertions, 0 deletions