aboutsummaryrefslogtreecommitdiffstats
path: root/builtin/commit.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2023-07-03 02:33:30 -0400
committerJunio C Hamano <gitster@pobox.com>2023-07-05 10:16:53 -0700
commit84d689a810842c44d95ac759d39702dfa170093b (patch)
tree1f2c15f1463d0baa98076e8aa5fb5c747f83299f /builtin/commit.c
parentMerge branch 'jk/redact-h2h3-headers-fix' into maint-2.41 (diff)
downloadgit-84d689a810842c44d95ac759d39702dfa170093b.tar.gz
git-84d689a810842c44d95ac759d39702dfa170093b.zip
imap-send: use server conf argument in setup_curl()
Our caller passes in an imap_server_conf struct, but we ignore it totally, and instead read the config directly from the global "server" variable. This works OK, since our sole caller will pass in that same global variable. But the intent seems to have been to use the passed-in variable, as otherwise it has no purpose (and many other functions use the same pattern). Let's use the passed-in value, which also silences a -Wunused-parameter warning. It would be nice if "server" was not a global here, as we could avoid making similar mistakes. But changing that would be a larger refactor, as it must be accessed as a global in a few spots (e.g., filling it in with the config callback). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit.c')
0 files changed, 0 insertions, 0 deletions