diff options
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2017-06-14 13:35:46 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-06-15 12:31:43 -0700 |
| commit | e2e142510762712b4b005dca6c7a9676f93a3278 (patch) | |
| tree | 569f07b8d0e7de3fcd9c9a79ee88d98e9eb18592 /builtin/diff-files.c | |
| parent | discover_git_directory(): avoid setting invalid git_dir (diff) | |
| download | git-e2e142510762712b4b005dca6c7a9676f93a3278.tar.gz git-e2e142510762712b4b005dca6c7a9676f93a3278.zip | |
config: report correct line number upon error
When get_value() parses a key/value pair, it is possible that the line
number is decreased (because the \n has been consumed already) before the
key/value pair is passed to the callback function, to allow for the
correct line to be attributed in case of an error.
However, when git_parse_source() asks get_value() to parse the key/value
pair, the error reporting is performed *after* get_value() returns.
Which means that we have to be careful not to increase the line number
in get_value() after the callback function returned an error.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/diff-files.c')
0 files changed, 0 insertions, 0 deletions