diff options
| author | Karthik Nayak <karthik.188@gmail.com> | 2025-01-19 12:19:26 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2025-01-21 12:36:34 -0800 |
| commit | 8244d01de6402606c9fb588ce2143aa629aa7d0e (patch) | |
| tree | beec447534938776b2ebecb945192f1ec4057984 /builtin/pack-objects.c | |
| parent | Git 2.48 (diff) | |
| download | git-8244d01de6402606c9fb588ce2143aa629aa7d0e.tar.gz git-8244d01de6402606c9fb588ce2143aa629aa7d0e.zip | |
pack-write: pass hash_algo to `fixup_pack_header_footer()`
The `fixup_pack_header_footer()` function uses the global
`the_hash_algo` variable to access the repository's hash function. To
avoid global variable usage, pass a hash_algo from the layers above.
Altough the layers above could have access to the hash_algo internally,
simply pass in `the_hash_algo`. This avoids any compatibility issues and
bubbles up global variable usage to upper layers which can be eventually
resolved.
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/pack-objects.c')
| -rw-r--r-- | builtin/pack-objects.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index 1c3b842651..6188e82059 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -1318,8 +1318,9 @@ static void write_pack_file(void) */ int fd = finalize_hashfile(f, hash, FSYNC_COMPONENT_PACK, 0); - fixup_pack_header_footer(fd, hash, pack_tmp_name, - nr_written, hash, offset); + fixup_pack_header_footer(the_hash_algo, fd, hash, + pack_tmp_name, nr_written, + hash, offset); close(fd); if (write_bitmap_index) { if (write_bitmap_index != WRITE_BITMAP_QUIET) |