diff options
| author | Jeff King <peff@peff.net> | 2023-10-09 17:05:30 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-10-09 15:55:01 -0700 |
| commit | 2abd56e9b2195c8111ff5d16efafabc5bccba92b (patch) | |
| tree | f815b1abdd934dc70a3355deb5fcade1e7dd9dfa /commit-graph.c | |
| parent | midx: check size of object offset chunk (diff) | |
| download | git-2abd56e9b2195c8111ff5d16efafabc5bccba92b.tar.gz git-2abd56e9b2195c8111ff5d16efafabc5bccba92b.zip | |
midx: bounds-check large offset chunk
When we see a large offset bit in the regular midx offset table, we
use the entry as an index into a separate large offset table (just like
a pack idx does). But we don't bounds-check the access to that large
offset table (nor even record its size when we parse the chunk!).
The equivalent code for a regular pack idx is in check_pack_index_ptr().
But things are a bit simpler here because of the chunked format: we can
just check our array index directly.
As a bonus, we can get rid of the st_mult() here. If our array
bounds-check is successful, then we know that the result will fit in a
size_t (and the bounds check uses a division to avoid overflow
entirely).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'commit-graph.c')
0 files changed, 0 insertions, 0 deletions
