diff options
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2019-12-02 11:33:29 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-12-02 11:05:36 -0800 |
| commit | 3ba3720b3f187644ac0186a4637898f8e8f85a91 (patch) | |
| tree | 058bc3d372ba1317d96dd781f90f9a3e9b7061f4 /commit-reach.c | |
| parent | mingw: do set `errno` correctly when trying to restrict handle inheritance (diff) | |
| download | git-3ba3720b3f187644ac0186a4637898f8e8f85a91.tar.gz git-3ba3720b3f187644ac0186a4637898f8e8f85a91.zip | |
mingw: forbid translating ERROR_SUCCESS to an errno value
Johannes Sixt pointed out that the `err_win_to_posix()` function
mishandles `ERROR_SUCCESS`: it maps it to `ENOSYS`.
The only purpose of this function is to map Win32 API errors to `errno`
ones, and there is actually no equivalent to `ERROR_SUCCESS`: the idea
of `errno` is that it will only be set in case of an error, and left
alone in case of success.
Therefore, as pointed out by Junio Hamano, it is a bug to call this
function when there was not even any error to map.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'commit-reach.c')
0 files changed, 0 insertions, 0 deletions