diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-09-26 13:47:02 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-09-27 08:25:37 -0700 |
| commit | b6c3f8e12c0a521450923ddbcf7a19a81aa3c4e7 (patch) | |
| tree | d91bfec01734dda3b5ca03d861678d9cd043e043 /commit.c | |
| parent | builtin/maintenance: fix leaking config string (diff) | |
| download | git-b6c3f8e12c0a521450923ddbcf7a19a81aa3c4e7.tar.gz git-b6c3f8e12c0a521450923ddbcf7a19a81aa3c4e7.zip | |
builtin/maintenance: fix leak in `get_schedule_cmd()`
The `get_schedule_cmd()` function allows us to override the schedule
command with a specific test command such that we can verify the
underlying logic in a platform-independent way. Its memory management is
somewhat wild though, because it basically gives up and assigns an
allocated string to the string constant output pointer. While this part
is marked with `UNLEAK()` to mask this, we also leak the local string
lists.
Rework the function such that it has a separate out parameter. If set,
we will assign it the final allocated command. Plug the other memory
leaks and create a common exit path.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'commit.c')
0 files changed, 0 insertions, 0 deletions