diff options
| author | Maxim Cournoyer <maxim@guixotic.coop> | 2025-06-25 23:25:10 +0900 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2025-06-25 09:43:59 -0700 |
| commit | 53ca38298d69529e59e33a21e63040aef509bbf8 (patch) | |
| tree | 1b84f1ad23100d34790657e7640fa9c314ed9dfa /contrib/credential/netrc/git-credential-netrc.perl | |
| parent | contrib: use a more portable shebang for git-credential-netrc (diff) | |
| download | git-53ca38298d69529e59e33a21e63040aef509bbf8.tar.gz git-53ca38298d69529e59e33a21e63040aef509bbf8.zip | |
contrib: warn for invalid netrc file ports in git-credential-netrc
Invalid ports were previously silently dropped; now a warning message
is produced.
Signed-off-by: Maxim Cournoyer <maxim@guixotic.coop>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib/credential/netrc/git-credential-netrc.perl')
| -rwxr-xr-x | contrib/credential/netrc/git-credential-netrc.perl | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/contrib/credential/netrc/git-credential-netrc.perl b/contrib/credential/netrc/git-credential-netrc.perl index 514f68d00b..09d77b4f69 100755 --- a/contrib/credential/netrc/git-credential-netrc.perl +++ b/contrib/credential/netrc/git-credential-netrc.perl @@ -267,9 +267,14 @@ sub load_netrc { if (!defined $nentry->{machine}) { next; } - if (defined $nentry->{port} && $nentry->{port} =~ m/^\d+$/) { - $num_port = $nentry->{port}; - delete $nentry->{port}; + if (defined $nentry->{port}) { + if ($nentry->{port} =~ m/^\d+$/) { + $num_port = $nentry->{port}; + delete $nentry->{port}; + } else { + printf(STDERR "ignoring invalid port `%s' " . + "from netrc file\n", $nentry->{port}); + } } # create the new entry for the credential helper protocol |