diff options
| author | KJ Tsanaktsidis <kj@kjtsanaktsidis.id.au> | 2026-01-12 01:44:39 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2026-01-11 20:54:01 -0800 |
| commit | a8227ae8d5410e54c5788283e35b42b7bf5b22ff (patch) | |
| tree | 4d18ed05e7de065b096ae0c6ad3b9e9a8ae0b4b7 /contrib/persistent-https | |
| parent | Git 2.52 (diff) | |
| download | git-a8227ae8d5410e54c5788283e35b42b7bf5b22ff.tar.gz git-a8227ae8d5410e54c5788283e35b42b7bf5b22ff.zip | |
http-backend: write newlines to stderr when responding with errors
The not_found and forbidden methods currently do not write a newline to
stderr after the error message. This means that if git-http-backend is
invoked through something like fcgiwrap, and the stderr of that fcgiwrap
process is sent to a logging daemon (e.g. journald), the error messages
of several git-http-backend invocations will just get strung together,
e.g.
> Not a git repository: '/var/lib/git/foo.git'Not a git repository: '/var/lib/git/foo.git'Not a git repository: '/var/lib/git/foo.git'
I think it's git-http-backend's responsibility to format these messages
properly, rather than it being fcgiwrap's job to notice that the script
didn't terminate stderr with a newline and do so itself.
Signed-off-by: KJ Tsanaktsidis <kj@kjtsanaktsidis.id.au>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib/persistent-https')
0 files changed, 0 insertions, 0 deletions