diff options
| author | Han-Wen Nienhuys <hanwen@google.com> | 2022-01-20 15:12:13 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-01-20 11:31:53 -0800 |
| commit | 66c0dabab5e15f78d0505be36cac4a383e14cf88 (patch) | |
| tree | db6fd2622162b3d16eceb899975472e16d14e2c3 /diff.c | |
| parent | reftable: remove outdated file reftable.c (diff) | |
| download | git-66c0dabab5e15f78d0505be36cac4a383e14cf88.tar.gz git-66c0dabab5e15f78d0505be36cac4a383e14cf88.zip | |
reftable: make reftable_record a tagged union
This reduces the amount of glue code, because we don't need a void
pointer or vtable within the structure.
The only snag is that reftable_index_record contain a strbuf, so it
cannot be zero-initialized. To address this, use reftable_new_record()
to return fresh instance, given a record type. Since
reftable_new_record() doesn't cause heap allocation anymore, it should
be balanced with reftable_record_release() rather than
reftable_record_destroy().
Thanks to Peff for the suggestion.
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'diff.c')
0 files changed, 0 insertions, 0 deletions
