aboutsummaryrefslogtreecommitdiffstats
path: root/exec-cmd.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2022-10-17 21:02:02 -0400
committerJunio C Hamano <gitster@pobox.com>2022-10-17 21:24:03 -0700
commit70aa1d7576830c5efa93953ccded77deb0d7eb25 (patch)
tree394f5a109062ae75d179ee305d6981f2bc9d9111 /exec-cmd.c
parentdiffstat_consume(): assert non-zero length (diff)
downloadgit-70aa1d7576830c5efa93953ccded77deb0d7eb25.tar.gz
git-70aa1d7576830c5efa93953ccded77deb0d7eb25.zip
submodule--helper: drop unused argc from module_list_compute()
The module_list_compute() function takes an argc/argv pair, but never looks at argc. This is OK, as the NULL terminator in argv is sufficient for our purposes (we feed it to parse_pathspec(), which takes only the array, not a count). Note that one of the callers _looks_ like it would be buggy, but isn't: we pass 0/NULL for argc/argv from module_foreach(), so finding the terminating NULL in that argv naively would segfault. However, parse_pathspec() is smart enough to interpret a bare NULL as an empty argv. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'exec-cmd.c')
0 files changed, 0 insertions, 0 deletions