diff options
| author | Jakub Narebski <jnareb@gmail.com> | 2009-05-10 02:38:34 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2009-05-10 21:18:49 -0700 |
| commit | dff2b6d4842eef0a03a3c8b3761f72e2b55b609e (patch) | |
| tree | fafc33fe52eac4fef8d5793b2d0dd43788ee426c /gitweb/static/js/javascript-detection.js | |
| parent | gitweb: Do not use bareword filehandles (diff) | |
| download | git-dff2b6d4842eef0a03a3c8b3761f72e2b55b609e.tar.gz git-dff2b6d4842eef0a03a3c8b3761f72e2b55b609e.zip | |
gitweb: Always use three argument form of open
In most cases (except insert_file() subroutine) we used old two argument
form of 'open' to open files for reading. This can cause subtle bugs when
$projectroot or $projects_list file starts with mode characters ('>', '<',
'+<', '|', etc.) or with leading whitespace; and also when $projects_list
file or $mimetypes_file or ctags files end with trailing whitespace or '|'.
Additionally it is also more clear to explicitly state that we open those
files for reading.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'gitweb/static/js/javascript-detection.js')
0 files changed, 0 insertions, 0 deletions
