diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-06-11 11:19:59 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-06-11 13:15:05 -0700 |
| commit | f87c55c2647cf3aa0e6b5e45738facb6b62fe37c (patch) | |
| tree | 1b098b88ceb32ecad516fbd68b93642a5488fd8e /list-objects-filter.c | |
| parent | builtin/rev-list: fix leaking bitmap index when calculating disk usage (diff) | |
| download | git-f87c55c2647cf3aa0e6b5e45738facb6b62fe37c.tar.gz git-f87c55c2647cf3aa0e6b5e45738facb6b62fe37c.zip | |
object-name: free leaking object contexts
While it is documented in `struct object_context::path` that this
variable needs to be released by the caller, this fact is rather easy to
miss given that we do not ever provide a function to release the object
context. And of course, while some callers dutifully release the path,
many others don't.
Introduce a new `object_context_release()` function that releases the
path. Convert callsites that used to free the path to use that new
function and add missing calls to callsites that were leaking memory.
Refactor those callsites as required to have a single return path, only.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'list-objects-filter.c')
| -rw-r--r-- | list-objects-filter.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/list-objects-filter.c b/list-objects-filter.c index 4346f8da45..c95ec3509a 100644 --- a/list-objects-filter.c +++ b/list-objects-filter.c @@ -542,6 +542,8 @@ static void filter_sparse_oid__init( filter->filter_data = d; filter->filter_object_fn = filter_sparse; filter->free_fn = filter_sparse_free; + + object_context_release(&oc); } /* |