diff options
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2020-04-11 13:40:22 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-04-11 14:24:40 -0700 |
| commit | 176a66a748c18132ebb747553896b810993179a6 (patch) | |
| tree | e79804507efbc57568864269635c968a8a8b4d31 /t/test-lib-functions.sh | |
| parent | mingw: make test_path_is_hidden more robust (diff) | |
| download | git-176a66a748c18132ebb747553896b810993179a6.tar.gz git-176a66a748c18132ebb747553896b810993179a6.zip | |
t: restrict `is_hidden` to be called only on Windows
The function won't work anywhere else, so let's mark it as an explicit
bug if it is called on a non-Windows platform.
Let's also rename the function to avoid cluttering the global namespace
with an overly-generic function name.
While at it, we also fix the code comment above that function: the
lower-case `windows` refers to something different than `Windows`.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/test-lib-functions.sh')
| -rw-r--r-- | t/test-lib-functions.sh | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh index 2f81463a24..139647a634 100644 --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh @@ -1544,8 +1544,11 @@ test_bitmap_traversal () { rm -f "$1.normalized" "$2.normalized" } -# Tests for the hidden file attribute on windows -is_hidden () { +# Tests for the hidden file attribute on Windows +test_path_is_hidden () { + test_have_prereq MINGW || + BUG "test_path_is_hidden can only be used on Windows" + # Use the output of `attrib`, ignore the absolute path case "$("$SYSTEMROOT"/system32/attrib "$1")" in *H*?:*) return 0;; esac return 1 |