diff options
| author | Xing Guo <higuoxing@gmail.com> | 2025-10-16 11:53:30 +0800 |
|---|---|---|
| committer | Andrii Nakryiko <andrii@kernel.org> | 2025-10-16 09:34:39 -0700 |
| commit | 0c1999ed33722f85476a248186d6e0eb2bf3dd2a (patch) | |
| tree | 9f6b3ec5fb3a12ea15a900ab63374bacaca5ee0e | |
| parent | bpf: Replace bpf_map_kmalloc_node() with kmalloc_nolock() to allocate bpf_asy... (diff) | |
| download | linux-0c1999ed33722f85476a248186d6e0eb2bf3dd2a.tar.gz linux-0c1999ed33722f85476a248186d6e0eb2bf3dd2a.zip | |
selftests: arg_parsing: Ensure data is flushed to disk before reading.
test_parse_test_list_file writes some data to
/tmp/bpf_arg_parsing_test.XXXXXX and parse_test_list_file() will read
the data back. However, after writing data to that file, we forget to
call fsync() and it's causing testing failure in my laptop. This patch
helps fix it by adding the missing fsync() call.
Fixes: 64276f01dce8 ("selftests/bpf: Test_progs can read test lists from file")
Signed-off-by: Xing Guo <higuoxing@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20251016035330.3217145-1-higuoxing@gmail.com
| -rw-r--r-- | tools/testing/selftests/bpf/prog_tests/arg_parsing.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/testing/selftests/bpf/prog_tests/arg_parsing.c b/tools/testing/selftests/bpf/prog_tests/arg_parsing.c index fbf0d9c2f58b..e27d66b75fb1 100644 --- a/tools/testing/selftests/bpf/prog_tests/arg_parsing.c +++ b/tools/testing/selftests/bpf/prog_tests/arg_parsing.c @@ -144,6 +144,9 @@ static void test_parse_test_list_file(void) if (!ASSERT_OK(ferror(fp), "prepare tmp")) goto out_fclose; + if (!ASSERT_OK(fsync(fileno(fp)), "fsync tmp")) + goto out_fclose; + init_test_filter_set(&set); if (!ASSERT_OK(parse_test_list_file(tmpfile, &set, true), "parse file")) |