diff options
| author | Jan Kara <jack@suse.cz> | 2025-07-09 11:06:36 +0200 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2025-07-10 09:37:32 +0200 |
| commit | 3bc4e4410830d556b0f40dfa6671bfcaeacc1599 (patch) | |
| tree | bbce951d228661a21054c030977ffb3c75892515 | |
| parent | fs/libfs: don't assume blocksize <= PAGE_SIZE in generic_check_addressable (diff) | |
| download | linux-3bc4e4410830d556b0f40dfa6671bfcaeacc1599.tar.gz linux-3bc4e4410830d556b0f40dfa6671bfcaeacc1599.zip | |
vfs: Remove unnecessary list_for_each_entry_safe() from evict_inodes()
evict_inodes() uses list_for_each_entry_safe() to iterate sb->s_inodes
list. However, since we use i_lru list entry for our local temporary
list of inodes to destroy, the inode is guaranteed to stay in
sb->s_inodes list while we hold sb->s_inode_list_lock. So there is no
real need for safe iteration variant and we can use
list_for_each_entry() just fine.
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/20250709090635.26319-2-jack@suse.cz
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/inode.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/inode.c b/fs/inode.c index a0150e2ef22a..01ebdc40021e 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -865,12 +865,12 @@ static void dispose_list(struct list_head *head) */ void evict_inodes(struct super_block *sb) { - struct inode *inode, *next; + struct inode *inode; LIST_HEAD(dispose); again: spin_lock(&sb->s_inode_list_lock); - list_for_each_entry_safe(inode, next, &sb->s_inodes, i_sb_list) { + list_for_each_entry(inode, &sb->s_inodes, i_sb_list) { if (atomic_read(&inode->i_count)) continue; |