diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2019-09-04 14:16:11 +0000 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2019-09-06 17:11:36 +0300 |
| commit | 4c3e48794dec7cb568974ba3bf2ab62b9c45ca3e (patch) | |
| tree | bdff92d4e6c29e27b6b97d9777c2d9c7002cdda4 | |
| parent | rtw88: fix seq_file memory leak (diff) | |
| download | linux-4c3e48794dec7cb568974ba3bf2ab62b9c45ca3e.tar.gz linux-4c3e48794dec7cb568974ba3bf2ab62b9c45ca3e.zip | |
rtlwifi: Fix file release memory leak
When using single_open() for opening, single_release() should be
used instead of seq_release(), otherwise there is a memory leak.
This is detected by Coccinelle semantic patch.
Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
| -rw-r--r-- | drivers/net/wireless/realtek/rtlwifi/debug.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.c b/drivers/net/wireless/realtek/rtlwifi/debug.c index a051de16284d..55db71c766fe 100644 --- a/drivers/net/wireless/realtek/rtlwifi/debug.c +++ b/drivers/net/wireless/realtek/rtlwifi/debug.c @@ -88,7 +88,7 @@ static const struct file_operations file_ops_common = { .open = dl_debug_open_common, .read = seq_read, .llseek = seq_lseek, - .release = seq_release, + .release = single_release, }; static int rtl_debug_get_mac_page(struct seq_file *m, void *v) |