diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2024-07-15 07:22:44 -0700 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2024-07-31 10:43:53 -0700 |
| commit | 696dbe45fb1739eee853b1a110b5001b898031c8 (patch) | |
| tree | 04cb1a73d6741414a94e37cd9c89935acd146896 | |
| parent | hwmon: (max1668) Reorder include files to alphabetic order (diff) | |
| download | linux-696dbe45fb1739eee853b1a110b5001b898031c8.tar.gz linux-696dbe45fb1739eee853b1a110b5001b898031c8.zip | |
hwmon: (max1668) Use BIT macro
Use bit macro to make the code easier to understand and reduce duplication.
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/max1668.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/hwmon/max1668.c b/drivers/hwmon/max1668.c index f5b5cc29da17..83085ed0ae7e 100644 --- a/drivers/hwmon/max1668.c +++ b/drivers/hwmon/max1668.c @@ -6,6 +6,7 @@ * some credit to Christoph Scheurer, but largely a rewrite */ +#include <linux/bits.h> #include <linux/err.h> #include <linux/hwmon.h> #include <linux/hwmon-sysfs.h> @@ -172,7 +173,7 @@ static ssize_t show_alarm(struct device *dev, struct device_attribute *attr, if (IS_ERR(data)) return PTR_ERR(data); - return sprintf(buf, "%u\n", (data->alarms >> index) & 0x1); + return sprintf(buf, "%u\n", !!(data->alarms & BIT(index))); } static ssize_t show_fault(struct device *dev, @@ -185,7 +186,7 @@ static ssize_t show_fault(struct device *dev, return PTR_ERR(data); return sprintf(buf, "%u\n", - (data->alarms & (1 << 12)) && data->temp[index] == 127); + (data->alarms & BIT(12)) && data->temp[index] == 127); } static ssize_t set_temp_max(struct device *dev, |