aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThorsten Blum <thorsten.blum@linux.dev>2025-08-11 18:40:38 +0200
committerJakub Kicinski <kuba@kernel.org>2025-08-12 17:13:29 -0700
commitb3ba7d929ce197ff2651046798b94bd62eb0e680 (patch)
tree5c3bda5c983af15972a69b0e8b03b086d9970a47
parentphonet: add __rcu annotations (diff)
downloadlinux-b3ba7d929ce197ff2651046798b94bd62eb0e680.tar.gz
linux-b3ba7d929ce197ff2651046798b94bd62eb0e680.zip
net/sched: Remove redundant memset(0) call in reset_policy()
The call to nla_strscpy() already zero-pads the tail of the destination buffer which makes the additional memset(0) call redundant. Remove it. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Reviewed-by: Joe Damato <joe@dama.to> Link: https://patch.msgid.link/20250811164039.43250-1-thorsten.blum@linux.dev Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r--net/sched/act_simple.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c
index f3abe0545989..8e69a919b4fe 100644
--- a/net/sched/act_simple.c
+++ b/net/sched/act_simple.c
@@ -72,7 +72,6 @@ static int reset_policy(struct tc_action *a, const struct nlattr *defdata,
d = to_defact(a);
spin_lock_bh(&d->tcf_lock);
goto_ch = tcf_action_set_ctrlact(a, p->action, goto_ch);
- memset(d->tcfd_defdata, 0, SIMP_MAX_DATA);
nla_strscpy(d->tcfd_defdata, defdata, SIMP_MAX_DATA);
spin_unlock_bh(&d->tcf_lock);
if (goto_ch)