diff options
| author | Andrii Nakryiko <andrii@kernel.org> | 2021-11-07 08:55:20 -0800 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2021-11-07 09:14:15 -0800 |
| commit | f91231eeeed752119f49eb6620cae44ec745a007 (patch) | |
| tree | 59b6dc423bef1504e4fdb7be307cf1b8546aa4f2 | |
| parent | selftests/bpf: Avoid duplicate btf__parse() call (diff) | |
| download | linux-f91231eeeed752119f49eb6620cae44ec745a007.tar.gz linux-f91231eeeed752119f49eb6620cae44ec745a007.zip | |
selftests/bpf: Destroy XDP link correctly
bpf_link__detach() was confused with bpf_link__destroy() and leaves
leaked FD in the process. Fix the problem.
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Reviewed-by: Hengqi Chen <hengqi.chen@gmail.com>
Link: https://lore.kernel.org/bpf/20211107165521.9240-9-andrii@kernel.org
| -rw-r--r-- | tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c b/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c index 7589c03fd26b..eb2feaac81fe 100644 --- a/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c +++ b/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c @@ -204,8 +204,8 @@ static int pass_ack(struct migrate_reuseport_test_case *test_case) { int err; - err = bpf_link__detach(test_case->link); - if (!ASSERT_OK(err, "bpf_link__detach")) + err = bpf_link__destroy(test_case->link); + if (!ASSERT_OK(err, "bpf_link__destroy")) return -1; test_case->link = NULL; |