diff options
| author | Rob Clark <robdclark@chromium.org> | 2023-07-24 13:30:21 -0700 |
|---|---|---|
| committer | Rob Clark <robdclark@chromium.org> | 2023-07-26 10:50:04 -0700 |
| commit | 1b5d0ddcb34a605835051ae2950d5cfed0373dd8 (patch) | |
| tree | 7ff7ef590d6199e16c93bf0937c2393dd28a3620 /drivers/gpu/drm/msm/msm_gem_submit.c | |
| parent | drm/msm: Fix hw_fence error path cleanup (diff) | |
| download | linux-1b5d0ddcb34a605835051ae2950d5cfed0373dd8.tar.gz linux-1b5d0ddcb34a605835051ae2950d5cfed0373dd8.zip | |
drm/msm: Disallow submit with fence id 0
A fence id of zero is expected to be invalid, and is not removed from
the fence_idr table. If userspace is requesting to specify the fence
id with the FENCE_SN_IN flag, we need to reject a zero fence id value.
Fixes: 17154addc5c1 ("drm/msm: Add MSM_SUBMIT_FENCE_SN_IN")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/549180/
Diffstat (limited to 'drivers/gpu/drm/msm/msm_gem_submit.c')
| -rw-r--r-- | drivers/gpu/drm/msm/msm_gem_submit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index 9d66498cdc04..63c96416e183 100644 --- a/drivers/gpu/drm/msm/msm_gem_submit.c +++ b/drivers/gpu/drm/msm/msm_gem_submit.c @@ -901,7 +901,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, * after the job is armed */ if ((args->flags & MSM_SUBMIT_FENCE_SN_IN) && - idr_find(&queue->fence_idr, args->fence)) { + (!args->fence || idr_find(&queue->fence_idr, args->fence))) { spin_unlock(&queue->idr_lock); idr_preload_end(); ret = -EINVAL; |