diff options
| author | Rosen Penev <rosenp@gmail.com> | 2024-10-30 13:37:17 -0700 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-11-03 14:37:42 -0800 |
| commit | 18082a84a7f06e9a4029daaf5a927e1e3f34f7ad (patch) | |
| tree | e6b00dbd8492e9ef73ced2972adfbaee32b0315a /drivers/net/ethernet/ibm/emac/tah.c | |
| parent | net: ibm: emac: tah: use devm for kzalloc (diff) | |
| download | linux-18082a84a7f06e9a4029daaf5a927e1e3f34f7ad.tar.gz linux-18082a84a7f06e9a4029daaf5a927e1e3f34f7ad.zip | |
net: ibm: emac: tah: use devm for mutex_init
It seems that since inception, this driver never called mutex_destroy in
_remove. Use devm to handle this automatically.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://patch.msgid.link/20241030203727.6039-3-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/ibm/emac/tah.c')
| -rw-r--r-- | drivers/net/ethernet/ibm/emac/tah.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ibm/emac/tah.c b/drivers/net/ethernet/ibm/emac/tah.c index 267c23ec15d7..4b325505053b 100644 --- a/drivers/net/ethernet/ibm/emac/tah.c +++ b/drivers/net/ethernet/ibm/emac/tah.c @@ -90,13 +90,17 @@ static int tah_probe(struct platform_device *ofdev) struct device_node *np = ofdev->dev.of_node; struct tah_instance *dev; struct resource regs; + int err; dev = devm_kzalloc(&ofdev->dev, sizeof(struct tah_instance), GFP_KERNEL); if (!dev) return -ENOMEM; - mutex_init(&dev->lock); + err = devm_mutex_init(&ofdev->dev, &dev->lock); + if (err) + return err; + dev->ofdev = ofdev; if (of_address_to_resource(np, 0, ®s)) { |