diff options
| author | Takashi Iwai <tiwai@suse.de> | 2020-03-11 09:47:11 +0100 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2020-03-12 15:43:39 +0200 |
| commit | d3f8c708c0d7c8b2b2bc5d3ba5c7d8a5a0af5f2b (patch) | |
| tree | cac569289ea1fa0570650fbde6d79e6fc064bf44 /drivers/net/wireless/broadcom/b43legacy | |
| parent | b43: Use scnprintf() for avoiding potential buffer overflow (diff) | |
| download | linux-d3f8c708c0d7c8b2b2bc5d3ba5c7d8a5a0af5f2b.tar.gz linux-d3f8c708c0d7c8b2b2bc5d3ba5c7d8a5a0af5f2b.zip | |
b43legacy: Use scnprintf() for avoiding potential buffer overflow
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: b43-dev@lists.infradead.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/broadcom/b43legacy')
| -rw-r--r-- | drivers/net/wireless/broadcom/b43legacy/debugfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/broadcom/b43legacy/debugfs.c b/drivers/net/wireless/broadcom/b43legacy/debugfs.c index 082aab8353b8..fa133dfb2ecb 100644 --- a/drivers/net/wireless/broadcom/b43legacy/debugfs.c +++ b/drivers/net/wireless/broadcom/b43legacy/debugfs.c @@ -54,7 +54,7 @@ struct b43legacy_dfs_file * fops_to_dfs_file(struct b43legacy_wldev *dev, #define fappend(fmt, x...) \ do { \ if (bufsize - count) \ - count += snprintf(buf + count, \ + count += scnprintf(buf + count, \ bufsize - count, \ fmt , ##x); \ else \ |