diff options
| author | NeilBrown <neilb@suse.de> | 2023-12-15 11:56:31 +1100 |
|---|---|---|
| committer | Chuck Lever <chuck.lever@oracle.com> | 2023-12-15 10:23:46 -0500 |
| commit | 2a501f55cd641eb4d3c16a2eab0d678693fac663 (patch) | |
| tree | 2a18ad5f59faa05fb603a973f45060b1aef7db2b /fs/nfsd/nfssvc.c | |
| parent | NFSD: Fix checksum mismatches in the duplicate reply cache (diff) | |
| download | linux-2a501f55cd641eb4d3c16a2eab0d678693fac663.tar.gz linux-2a501f55cd641eb4d3c16a2eab0d678693fac663.zip | |
nfsd: call nfsd_last_thread() before final nfsd_put()
If write_ports_addfd or write_ports_addxprt fail, they call nfsd_put()
without calling nfsd_last_thread(). This leaves nn->nfsd_serv pointing
to a structure that has been freed.
So remove 'static' from nfsd_last_thread() and call it when the
nfsd_serv is about to be destroyed.
Fixes: ec52361df99b ("SUNRPC: stop using ->sv_nrthreads as a refcount")
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'fs/nfsd/nfssvc.c')
| -rw-r--r-- | fs/nfsd/nfssvc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c index fe61d9bbcc1f..d6939e23ffcf 100644 --- a/fs/nfsd/nfssvc.c +++ b/fs/nfsd/nfssvc.c @@ -542,7 +542,7 @@ static struct notifier_block nfsd_inet6addr_notifier = { /* Only used under nfsd_mutex, so this atomic may be overkill: */ static atomic_t nfsd_notifier_refcount = ATOMIC_INIT(0); -static void nfsd_last_thread(struct net *net) +void nfsd_last_thread(struct net *net) { struct nfsd_net *nn = net_generic(net, nfsd_net_id); struct svc_serv *serv = nn->nfsd_serv; |