diff options
| author | Andrea Righi <arighi@nvidia.com> | 2025-10-13 22:36:34 +0200 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2025-10-14 10:29:17 -1000 |
| commit | 05e63305c85c88141500f0a2fb02afcfba9396e1 (patch) | |
| tree | fc206e537b2672c403e51ec132c271dda17c7af9 /kernel/sched/ext.c | |
| parent | sched_ext: Allocate scx_kick_cpus_pnt_seqs lazily using kvzalloc() (diff) | |
| download | linux-05e63305c85c88141500f0a2fb02afcfba9396e1.tar.gz linux-05e63305c85c88141500f0a2fb02afcfba9396e1.zip | |
sched_ext: Fix scx_kick_pseqs corruption on concurrent scheduler loads
If we load a BPF scheduler while another scheduler is already running,
alloc_kick_pseqs() would be called again, overwriting the previously
allocated arrays.
Fix by moving the alloc_kick_pseqs() call after the scx_enable_state()
check, ensuring that the arrays are only allocated when a scheduler can
actually be loaded.
Fixes: 14c1da3895a11 ("sched_ext: Allocate scx_kick_cpus_pnt_seqs lazily using kvzalloc()")
Signed-off-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/sched/ext.c')
| -rw-r--r-- | kernel/sched/ext.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index c645d47124e7..12c9c3595692 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -4577,15 +4577,15 @@ static int scx_enable(struct sched_ext_ops *ops, struct bpf_link *link) mutex_lock(&scx_enable_mutex); - ret = alloc_kick_pseqs(); - if (ret) - goto err_unlock; - if (scx_enable_state() != SCX_DISABLED) { ret = -EBUSY; - goto err_free_pseqs; + goto err_unlock; } + ret = alloc_kick_pseqs(); + if (ret) + goto err_unlock; + sch = scx_alloc_and_add_sched(ops); if (IS_ERR(sch)) { ret = PTR_ERR(sch); |