aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/tests/perf-targz-src-pkg
diff options
context:
space:
mode:
authorJames Clark <james.clark@linaro.org>2025-06-23 10:00:12 +0100
committerNamhyung Kim <namhyung@kernel.org>2025-06-26 10:31:05 -0700
commit2f5d370dec3f800b44bbf7b68875d521e0af43cd (patch)
tree98c7f302f54c4157c5eaf0228d3a4a7fc2b8df56 /tools/perf/tests/perf-targz-src-pkg
parentperf header: Don't write empty BPF/BTF info (diff)
downloadlinux-2f5d370dec3f800b44bbf7b68875d521e0af43cd.tar.gz
linux-2f5d370dec3f800b44bbf7b68875d521e0af43cd.zip
perf test: Change all remaining #!/bin/sh to #!/bin/bash
There are 43 instances of posix shell tests and 35 instances of bash. To give us a single consistent language for testing in, replace all #!/bin/sh to #!/bin/bash. Common sources that are included in both different shells will now work as expected. And we no longer have to fix up bashisms that appear to work when someone's system has sh symlinked to bash, but don't work on other systems that have both shells installed. Although we could have chosen sh, it's not backwards compatible so it wouldn't be possible to bulk convert without re-writing the existing bash tests. Choosing bash also gives us some nicer features including 'local' variable definitions and regexes in if statements that are already widely used in the tests. It's not expected that there are any users with only sh available due to the large number of bash tests that exist. Discussed in relation to running shellcheck here: https://lore.kernel.org/linux-perf-users/e3751a74be34bbf3781c4644f518702a7270220b.1749785642.git.collin.funk1@gmail.com/ Signed-off-by: James Clark <james.clark@linaro.org> Reviewed-by: Collin Funk <collin.funk1@gmail.com> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Link: https://lore.kernel.org/r/20250623-james-perf-bash-tests-v1-1-f572f54d4559@linaro.org Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/tests/perf-targz-src-pkg')
-rwxr-xr-xtools/perf/tests/perf-targz-src-pkg2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/tests/perf-targz-src-pkg b/tools/perf/tests/perf-targz-src-pkg
index b3075c168cb2..52a90e6bd8af 100755
--- a/tools/perf/tests/perf-targz-src-pkg
+++ b/tools/perf/tests/perf-targz-src-pkg
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
# Test one of the main kernel Makefile targets to generate a perf sources tarball
# suitable for build outside the full kernel sources.