diff options
| author | Maciej Fijalkowski <maciej.fijalkowski@intel.com> | 2022-01-25 17:04:44 +0100 |
|---|---|---|
| committer | Daniel Borkmann <daniel@iogearbox.net> | 2022-01-27 17:25:33 +0100 |
| commit | 86e3f78c8d324b410fbe79dcdc702a366e5c5341 (patch) | |
| tree | 79c49ed2f7ad7a2f79f52921bbfb2ade1a856655 /tools/testing/selftests/bpf/prog_tests/autoload.c | |
| parent | i40e: xsk: Move tmp desc array from driver to pool (diff) | |
| download | linux-86e3f78c8d324b410fbe79dcdc702a366e5c5341.tar.gz linux-86e3f78c8d324b410fbe79dcdc702a366e5c5341.zip | |
ice: xsk: Avoid potential dead AF_XDP Tx processing
Commit 9610bd988df9 ("ice: optimize XDP_TX workloads") introduced
@next_dd and @next_rs to ice_tx_ring struct. Currently, their state is
not restored in ice_clean_tx_ring(), which was not causing any troubles
as the XDP rings are gone after we're done with XDP prog on interface.
For upcoming usage of mentioned fields in AF_XDP, this might expose us
to a potential dead Tx side. Scenario would look like following (based
on xdpsock):
- two xdpsock instances are spawned in Tx mode
- one of them is killed
- XDP prog is kept on interface due to the other xdpsock still running
* this means that XDP rings stayed in place
- xdpsock is launched again on same queue id that was terminated on
- @next_dd and @next_rs setting is bogus, therefore transmit side is
broken
To protect us from the above, restore the initial @next_rs and @next_dd
values when cleaning the Tx ring.
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
Link: https://lore.kernel.org/bpf/20220125160446.78976-7-maciej.fijalkowski@intel.com
Diffstat (limited to 'tools/testing/selftests/bpf/prog_tests/autoload.c')
0 files changed, 0 insertions, 0 deletions
