diff options
| author | Amery Hung <ameryhung@gmail.com> | 2025-05-02 13:16:20 -0700 |
|---|---|---|
| committer | Martin KaFai Lau <martin.lau@kernel.org> | 2025-05-02 14:50:08 -0700 |
| commit | 659b3b2c488532140676affef036a1702fde6e32 (patch) | |
| tree | 322243467c79a00e446fcf1d240da3d1c72eba27 /tools/testing/selftests/bpf/prog_tests/prog_array_init.c | |
| parent | Merge branch 'bpf-udp-exactly-once-socket-iteration' (diff) | |
| download | linux-659b3b2c488532140676affef036a1702fde6e32.tar.gz linux-659b3b2c488532140676affef036a1702fde6e32.zip | |
bpf: net_sched: Fix bpf qdisc init prologue when set as default qdisc
Allow .init to proceed if qdisc_lookup() returns NULL as it only happens
when called by qdisc_create_dflt() in mq/mqprio_init and the parent qdisc
has not been added to qdisc_hash yet. In qdisc_create(), the caller,
__tc_modify_qdisc(), would have made sure the parent qdisc already exist.
In addition, call qdisc_watchdog_init() whether .init succeeds or not to
prevent null-pointer dereference. In qdisc_create() and
qdisc_create_dflt(), if .init fails, .destroy will be called. As a
result, the destroy epilogue could call qdisc_watchdog_cancel() with an
uninitialized timer, causing null-pointer deference in hrtimer_cancel().
Fixes: c8240344956e ("bpf: net_sched: Support implementation of Qdisc_ops in bpf")
Signed-off-by: Amery Hung <ameryhung@gmail.com>
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Diffstat (limited to 'tools/testing/selftests/bpf/prog_tests/prog_array_init.c')
0 files changed, 0 insertions, 0 deletions